Skip to content

[tests] add test and problem report uploading to the server test workflow #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 21, 2025
+8 −1
Merged

[tests] add test and problem report uploading to the server test workflow #94

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3711e2e
[tests] upload test report artifacts
pq Nov 21, 2025
9acdf06
try full path
pq Nov 21, 2025
55a141e
add problem report
pq Nov 21, 2025
cda38f9
path goofery
pq Nov 21, 2025
7b9760e
try inlining upload
pq Nov 21, 2025
c3a0318
+++
pq Nov 21, 2025
27e2cf0
---
pq Nov 21, 2025
384dfb0
${{ github.workspace }}
pq Nov 21, 2025
81a81d5
///
pq Nov 21, 2025
7b7cc5a
pluginVerifier
pq Nov 21, 2025
d7a3ddb
inline (again)
pq Nov 21, 2025
0e42252
moar pathery
pq Nov 21, 2025
19a83ec
--
pq Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,14 @@ jobs:
run: |
./gradlew :test --tests "com.jetbrains.dart.analysisServer.*"
working-directory: third_party

- name: Upload build artifacts
uses: actions/upload-artifact@v4
Copy link
Member

@jwren jwren Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, this is great! What does the CLI output look like, i.e. is it discoverable when it is written to these locations? Also, why not add this to to the Jobs?

Copy link
Collaborator Author

@pq pq Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been watching runs and it seems to work as intended! 🎉

(For example, this recent run: job/56077860294 generated artifacts here.)

What does the CLI output look like, i.e. is it discoverable when it is written to these locations?

If you squint at the picture above you can see a link is printed in the results. Here it is again:

image

Also, why not add this to to the Jobs?

You mean add a separate job? What would be the benefit?

(FWIW I did try actually try that initially but hit some snags and couldn't get the upload-artifact action to find the artifacts. I think I understand why after sleeping on it. If there's a good reason to get that working I can take another crack. Just let me know!)

if: always()
with:
name: build
path: |
**/build/reports/
**/build/test-results/
# Job 4: Verify Plugin
verify-plugin:
needs: build-plugin
Expand Down
Loading