Skip to content

Temporarily disable widget tests in inspector_service_test #9396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2025
Merged

Temporarily disable widget tests in inspector_service_test #9396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f4c825
Disable widget tests in inspector_service_test
elliette Aug 18, 2025
2c6851a
Update flutter candidate
elliette Aug 18, 2025
28b19e6
Merge branch 'master' into test-followup
elliette Aug 18, 2025
4658136
Format
elliette Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter-candidate.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
52af7a5040254357f2ab98723b51bbd92d4e6337
78df185e5a8da5290246fb25d3c81851834c729a
229 changes: 119 additions & 110 deletions packages/devtools_app/test/shared/diagnostics/inspector_service_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,132 +261,141 @@ void main() {
});
});

group('widget trees', () {
test('isSummaryTree = true', () async {
await env.setupEnvironment();
final group = inspectorService!.createObjectGroup('test-group');
final root = (await group.getRoot(
FlutterTreeType.widget,
isSummaryTree: true,
))!;
// Tree only contains widgets from local app.
expect(
treeToDebugString(root),
equals(
equalsGoldenIgnoringHashCodes(
'inspector_service_tree_summary.txt',
group(
'widget trees',
() {
test('isSummaryTree = true', () async {
await env.setupEnvironment();
final group = inspectorService!.createObjectGroup('test-group');
final root = (await group.getRoot(
FlutterTreeType.widget,
isSummaryTree: true,
))!;
// Tree only contains widgets from local app.
expect(
treeToDebugString(root),
equals(
equalsGoldenIgnoringHashCodes(
'inspector_service_tree_summary.txt',
),
),
),
);
final nodeInSummaryTree = findNodeMatching(root, 'MaterialApp')!;
expect(nodeInSummaryTree, isNotNull);
);
final nodeInSummaryTree = findNodeMatching(root, 'MaterialApp')!;
expect(nodeInSummaryTree, isNotNull);

expect(
treeToDebugString(nodeInSummaryTree),
equals(
equalsGoldenIgnoringHashCodes(
'inspector_service_node_summary.txt',
expect(
treeToDebugString(nodeInSummaryTree),
equals(
equalsGoldenIgnoringHashCodes(
'inspector_service_node_summary.txt',
),
),
),
);
);

await group.dispose();
});
await group.dispose();
});

test('isSummaryTree = false', () async {
await env.setupEnvironment();
final group = inspectorService!.createObjectGroup('test-group');
final root = (await group.getRoot(FlutterTreeType.widget))!;
// Tree contains all widgets.
expect(
treeToDebugString(root),
equals(
equalsGoldenIgnoringHashCodes(
'inspector_service_tree_no_summary.txt',
test('isSummaryTree = false', () async {
await env.setupEnvironment();
final group = inspectorService!.createObjectGroup('test-group');
final root = (await group.getRoot(FlutterTreeType.widget))!;
// Tree contains all widgets.
expect(
treeToDebugString(root),
equals(
equalsGoldenIgnoringHashCodes(
'inspector_service_tree_no_summary.txt',
),
),
),
);
final nodeInTree = findNodeMatching(root, 'MaterialApp')!;
expect(nodeInTree, isNotNull);
expect(
treeToDebugString(nodeInTree),
equals(
equalsGoldenIgnoringHashCodes(
'inspector_service_node_no_summary.txt',
);
final nodeInTree = findNodeMatching(root, 'MaterialApp')!;
expect(nodeInTree, isNotNull);
expect(
treeToDebugString(nodeInTree),
equals(
equalsGoldenIgnoringHashCodes(
'inspector_service_node_no_summary.txt',
),
),
),
);
);

await group.dispose();
});
await group.dispose();
});

test('details tree', () async {
await env.setupEnvironment();
test('details tree', () async {
await env.setupEnvironment();

// First get a node in the summary tree:
final group = inspectorService!.createObjectGroup('test-group');
final root = (await group.getRoot(
FlutterTreeType.widget,
isSummaryTree: true,
))!;
RemoteDiagnosticsNode nodeInSummaryTree = findNodeMatching(
root,
'MaterialApp',
)!;
expect(nodeInSummaryTree, isNotNull);

// Then get the details tree for the node in the summary tree:
RemoteDiagnosticsNode nodeInDetailsTree = (await group
.getDetailsSubtree(nodeInSummaryTree))!;

// When flutter rolls, this string may sometimes change due to
// implementation details.
expect(
treeToDebugStringTruncated(nodeInDetailsTree, 30),
equalsGoldenIgnoringHashCodes('inspector_service_details_tree.txt'),
);
// First get a node in the summary tree:
final group = inspectorService!.createObjectGroup('test-group');
final root = (await group.getRoot(
FlutterTreeType.widget,
isSummaryTree: true,
))!;
RemoteDiagnosticsNode nodeInSummaryTree = findNodeMatching(
root,
'MaterialApp',
)!;
expect(nodeInSummaryTree, isNotNull);

// Then get the details tree for the node in the summary tree:
RemoteDiagnosticsNode nodeInDetailsTree = (await group
.getDetailsSubtree(nodeInSummaryTree))!;

// When flutter rolls, this string may sometimes change due to
// implementation details.
expect(
treeToDebugStringTruncated(nodeInDetailsTree, 30),
equalsGoldenIgnoringHashCodes(
'inspector_service_details_tree.txt',
),
);

nodeInSummaryTree = findNodeMatching(root, 'Text')!;
expect(nodeInSummaryTree, isNotNull);
expect(
treeToDebugString(nodeInSummaryTree),
equalsIgnoringHashCodes('Text\n'),
);
nodeInSummaryTree = findNodeMatching(root, 'Text')!;
expect(nodeInSummaryTree, isNotNull);
expect(
treeToDebugString(nodeInSummaryTree),
equalsIgnoringHashCodes('Text\n'),
);

nodeInDetailsTree = (await group.getDetailsSubtree(
nodeInSummaryTree,
))!;
nodeInDetailsTree = (await group.getDetailsSubtree(
nodeInSummaryTree,
))!;

expect(
treeToDebugString(nodeInDetailsTree),
equalsGoldenIgnoringHashCodes(
'inspector_service_text_details_tree.txt',
),
);
expect(
treeToDebugString(nodeInDetailsTree),
equalsGoldenIgnoringHashCodes(
'inspector_service_text_details_tree.txt',
),
);

expect(
nodeInDetailsTree.valueRef,
equals(nodeInSummaryTree.valueRef),
);
expect(
nodeInDetailsTree.valueRef,
equals(nodeInSummaryTree.valueRef),
);

await group.setSelectionInspector(nodeInDetailsTree.valueRef, true);
final selection = (await group.getSelection(
null,
FlutterTreeType.widget,
))!;
expect(selection, isNotNull);
expect(selection.valueRef, equals(nodeInDetailsTree.valueRef));
expect(
treeToDebugString(selection),
equalsIgnoringHashCodes(
'Text\n'
' └─RichText\n',
),
);
await group.setSelectionInspector(nodeInDetailsTree.valueRef, true);
final selection = (await group.getSelection(
null,
FlutterTreeType.widget,
))!;
expect(selection, isNotNull);
expect(selection.valueRef, equals(nodeInDetailsTree.valueRef));
expect(
treeToDebugString(selection),
equalsIgnoringHashCodes(
'Text\n'
' └─RichText\n',
),
);

await group.dispose();
});
});
await group.dispose();
});
},
// TODO(https://github.com/flutter/devtools/issues/9395): Tests should be
// re-enabled once they are no longer dependant on widget ordering in the
// framework.
skip: true,
);

test('enables hover eval mode by default', () async {
await env.setupEnvironment();
Expand Down
Loading