Skip to content

Conversation

kreazyme
Copy link

@kreazyme kreazyme commented Aug 30, 2025

Fixes #9429

Before After
image image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@kreazyme kreazyme requested a review from a team as a code owner August 30, 2025 03:39
@kreazyme kreazyme requested review from elliette and removed request for a team August 30, 2025 03:39
Copy link

google-cla bot commented Aug 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Please sign the CLA and include an issue link in your PR description. Thank you!

@kreazyme
Copy link
Author

kreazyme commented Sep 9, 2025

Hi @elliette , thank for your review
I signed CLA, and here are issue link
#9429

@kreazyme kreazyme requested a review from elliette September 10, 2025 15:54
@elliette
Copy link
Member

Thank you! Change looks good. But it doesn't look like the CLA has been signed yet. Thanks!

@kreazyme
Copy link
Author

Hi @elliette , I already signed to CLA, can you re-run the check CLA action ?

Copy link
Contributor

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you provide an example request string that hits this crash?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request network tab showing empty page when null data
3 participants