Skip to content

handle show null data in JsonViewer #9418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −3
Open

handle show null data in JsonViewer #9418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/devtools_app/lib/src/shared/ui/common_widgets.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,8 +1085,11 @@ class TextViewer extends StatelessWidget {
}

class JsonViewer extends StatefulWidget {
JsonViewer({super.key, required this.encodedJson, this.scrollable = true})
: assert(encodedJson.isNotEmpty);
const JsonViewer({
super.key,
required this.encodedJson,
this.scrollable = true,
});

final String encodedJson;
final bool scrollable;
Expand All @@ -1111,7 +1114,7 @@ class _JsonViewerState extends State<JsonViewer> {
}

void _updateVariablesTree() {
assert(widget.encodedJson.isNotEmpty);
if (widget.encodedJson.isEmpty) return;
final responseJson = json.decode(widget.encodedJson);
// Insert the JSON data into the fake service cache so we can use it with
// the `ExpandableVariable` widget.
Expand Down Expand Up @@ -1197,6 +1200,12 @@ class _JsonViewerState extends State<JsonViewer> {

@override
Widget build(BuildContext context) {
if (widget.encodedJson.isEmpty) {
return const Padding(
padding: EdgeInsetsGeometry.only(top: 16.0),
child: CenteredMessage(message: 'No JSON data'),
);
}
Widget child = FutureBuilder(
future: _initializeTree,
builder: (context, snapshot) {
Expand Down