Add verify and test steps to dev build #8455
Conversation
| ./gradlew verifyPluginProjectConfiguration | ||
| ./gradlew verifyPluginStructure | ||
| ./gradlew verifyPluginSignature | ||
| ./gradlew verifyPlugin |
There was a problem hiding this comment.
Out of curiosity, would it make sense to add a kind of macro verifyAll command?
(Obviously not required here but I'm curious what happens when we add a new verification; would we have to remember to update this script and others to include it?)
There was a problem hiding this comment.
In the gradle build file, yes I believe that we could add a new task to call of of these with some, verifyAll alias if we want to.
There was a problem hiding this comment.
We could add something like that to gradle. I don't even know what each of these contain.
| ./gradlew verifyPluginProjectConfiguration | ||
| ./gradlew verifyPluginStructure | ||
| ./gradlew verifyPluginSignature | ||
| ./gradlew verifyPlugin |
There was a problem hiding this comment.
In the gradle build file, yes I believe that we could add a new task to call of of these with some, verifyAll alias if we want to.
helin24
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter-intellij/8455, because - The status or check suite checker (UNIT_TEST_BOT) has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
Presubmit failing should be fixed once flutter/flutter#173731 lands |
There are several things happening here: - Use semver format for CHANGELOG - this makes it easier to use the gradle changelog plugin, so we don't have to define a custom regex for our versioning. - Set release version from CHANGELOG - as long as we update the changelog as part of the release process, we won't have to separately set the version in `gradle.properties`. The two should match during a release anyway. - Set dev version from CHANGELOG - this means we won't need to update a hard coded version in the deploy script. (will rebase after #8455) Addresses #8417
I can't test that these work without pointing kokoro to a different branch, so I figure I'll just run a test after this is committed to main branch.