Skip to content

Add verify and test steps to dev build #8455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

Add verify and test steps to dev build #8455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tool/kokoro/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,21 @@
source ./tool/kokoro/setup.sh
setup

echo "kokoro verify start"

./gradlew verifyPluginProjectConfiguration
./gradlew verifyPluginStructure
./gradlew verifyPluginSignature
./gradlew verifyPlugin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, would it make sense to add a kind of macro verifyAll command?

(Obviously not required here but I'm curious what happens when we add a new verification; would we have to remember to update this script and others to include it?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the gradle build file, yes I believe that we could add a new task to call of of these with some, verifyAll alias if we want to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add something like that to gradle. I don't even know what each of these contain.


echo "kokoro verify finished"

echo "kokoro test start"

./gradlew test

echo "kokoro test finished"

echo "kokoro build start"

./gradlew buildPlugin -Pdev-version=88.0
Expand Down