Correcting some items in the breaking changes index #12902
Conversation
Summary of ChangesHello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses inaccuracies in the breaking changes index by correcting the placement of two specific breaking change entries. The changes ensure that the documentation accurately reflects the release versions associated with these breaking changes, thereby improving the clarity and correctness of the release notes for users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to correct the placement of several breaking changes in the index file. However, based on the content of the documentation files for these breaking changes, the new placements appear to be incorrect. Both 'Stop generating AssetManifest.json' and '$FLUTTER_ROOT/version replaced by $FLUTTER_ROOT/bin/cache/flutter.version.json' seem to be slated for future releases, not the ones they've been moved to. Additionally, there's a minor formatting inconsistency introduced with an extra newline. Please see the detailed comments for more information.
| * [Flutter now sets default `abiFilters` in Android builds][] | ||
| * [Merged threads on macOS and Windows][] | ||
| * [The `Visibility` widget is no longer focusable by default when `maintainState` is enabled][] | ||
| * [`$FLUTTER_ROOT/version` replaced by `$FLUTTER_ROOT/bin/cache/flutter.version.json`][] |
There was a problem hiding this comment.
This change moves the '$FLUTTER_ROOT/version replaced by $FLUTTER_ROOT/bin/cache/flutter.version.json' breaking change to the 'Released in Flutter 3.35' section. However, the corresponding documentation file (src/content/release/breaking-changes/flutter-root-version-file.md) states 'Stable release: Not published yet'. This suggests the change should remain in the 'Not yet released to stable' section. Please verify the correct release for this change.
| * [Deprecate imperative apply of Flutter's Gradle plugins][] | ||
| * [Default multitouch scrolling][] | ||
| * [Accessibility traversal order of tooltip changed][] | ||
| * [Stop generating `AssetManifest.json`][] |
There was a problem hiding this comment.
This change moves the 'Stop generating AssetManifest.json' breaking change to the 'Released in Flutter 3.19' section. However, according to src/content/release/breaking-changes/asset-manifest-dot-json.md, this change will be effective 'starting with the fourth stable release after 3.19 or one year after the release of 3.19, whichever comes later'. This implies it was not released in 3.19 and should probably stay in the 'Not yet released to stable' section. Please confirm the correct placement.
| [Rename `MemoryAllocations` to `FlutterMemoryAllocations`]: /release/breaking-changes/flutter-memory-allocations | ||
|
|
||
| <a id="released-in-flutter-319" aria-hidden="true"></a> | ||
|
|
There was a problem hiding this comment.
This added blank line makes the formatting inconsistent with other release sections in this file, which don't have a blank line between the anchor tag and the heading. For consistency, please remove this line.
|
Visit the preview URL for this PR (updated for commit ee86c0b): https://flutter-docs-prod--pr12902-breaking-llsxrd0z.web.app |
5 participants
@bkonyi, @loic-sharma noticed some breaking changes that were misplaced when the site was migrated. Can you confirm these corrections?