Skip to content

Correcting some items in the breaking changes index #12902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfshaza2 merged 1 commit into from
Jan 9, 2026
+3 −2
Merged

Correcting some items in the breaking changes index #12902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/content/release/breaking-changes/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ They're sorted by release and listed in alphabetical order:
### Not yet released to stable

* [Merged threads on Linux][]
* [Stop generating `AssetManifest.json`][]
* [`$FLUTTER_ROOT/version` replaced by `$FLUTTER_ROOT/bin/cache/flutter.version.json`][]
* [`FontWeight` also controls the weight attribute of variable fonts][]
* [Deprecate `containsSemantics` in favor of `isSemantics`][]
* [Deprecate `findChildIndexCallback` in favor of `findItemIndexCallback` in `ListView` and `SliverList` separated constructors][]
Expand Down Expand Up @@ -83,6 +81,7 @@ They're sorted by release and listed in alphabetical order:
* [Flutter now sets default `abiFilters` in Android builds][]
* [Merged threads on macOS and Windows][]
* [The `Visibility` widget is no longer focusable by default when `maintainState` is enabled][]
* [`$FLUTTER_ROOT/version` replaced by `$FLUTTER_ROOT/bin/cache/flutter.version.json`][]
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change moves the '$FLUTTER_ROOT/version replaced by $FLUTTER_ROOT/bin/cache/flutter.version.json' breaking change to the 'Released in Flutter 3.35' section. However, the corresponding documentation file (src/content/release/breaking-changes/flutter-root-version-file.md) states 'Stable release: Not published yet'. This suggests the change should remain in the 'Not yet released to stable' section. Please verify the correct release for this change.


[Component theme normalization updates]: /release/breaking-changes/component-theme-normalization-updates
[Deprecate `DropdownButtonFormField` `value` parameter in favor of `initialValue`]: /release/breaking-changes/deprecate-dropdownbuttonformfield-value
Expand Down Expand Up @@ -185,13 +184,15 @@ They're sorted by release and listed in alphabetical order:
[Rename `MemoryAllocations` to `FlutterMemoryAllocations`]: /release/breaking-changes/flutter-memory-allocations

<a id="released-in-flutter-319" aria-hidden="true"></a>

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This added blank line makes the formatting inconsistent with other release sections in this file, which don't have a blank line between the anchor tag and the heading. For consistency, please remove this line.

### Released in Flutter 3.19

* [Deprecated API removed after v3.16][]
* [Migrate RawKeyEvent/RawKeyboard system to KeyEvent/HardwareKeyboard system][]
* [Deprecate imperative apply of Flutter's Gradle plugins][]
* [Default multitouch scrolling][]
* [Accessibility traversal order of tooltip changed][]
* [Stop generating `AssetManifest.json`][]
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change moves the 'Stop generating AssetManifest.json' breaking change to the 'Released in Flutter 3.19' section. However, according to src/content/release/breaking-changes/asset-manifest-dot-json.md, this change will be effective 'starting with the fourth stable release after 3.19 or one year after the release of 3.19, whichever comes later'. This implies it was not released in 3.19 and should probably stay in the 'Not yet released to stable' section. Please confirm the correct placement.


[Deprecated API removed after v3.16]: /release/breaking-changes/3-16-deprecations
[Migrate RawKeyEvent/RawKeyboard system to KeyEvent/HardwareKeyboard system]: /release/breaking-changes/key-event-migration
Expand Down
Loading