Upgrade iOS SDK to v200.7 #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarekTolba1
commented
May 5, 2025
...map_sdk_ios/ios/arcgis_map_sdk_ios/Sources/arcgis_map_sdk_ios/ManualLocationDataSource.swift
Outdated
Show resolved
Hide resolved
JulianBissekkou
requested changes
May 5, 2025
Collaborator
JulianBissekkou
left a comment
JulianBissekkou
left a comment
There was a problem hiding this comment.
Solid work on this PR! 💪🏽
| import ArcGIS | ||
|
|
||
| class ManualLocationDataSource: AGSLocationDataSource { | ||
| final class CustomLocationProvider: LocationProvider { |
Collaborator
There was a problem hiding this comment.
Can you rename the file name to be CustomLocationProvider.swift?
...map_sdk_ios/ios/arcgis_map_sdk_ios/Sources/arcgis_map_sdk_ios/ManualLocationDataSource.swift
Outdated
Show resolved
Hide resolved
...map_sdk_ios/ios/arcgis_map_sdk_ios/Sources/arcgis_map_sdk_ios/ManualLocationDataSource.swift
Show resolved
Hide resolved
JulianBissekkou
approved these changes
May 6, 2025
JulianBissekkou
merged commit f4ccd88
into
migrate-ios-to-swift-package-manager
3 checks passed
Merged
JulianBissekkou
added a commit
that referenced
this pull request
May 16, 2025
* Migrate iOS plugin and example to swift package manager * Upgrade iOS SDK to v200.7 (#90) * Upgrade arcgis sdk * Upgrade arcgis sdk + create MapContentView * Fix few issues after upgrading sdk * Fix few issues after upgrading sdk * Clean code * fix build * reformat code * Update CustomLocationProvider.swift * Fix location indicator example --------- Co-authored-by: Julian Bissekkou <[email protected]> --------- Co-authored-by: Julian Bissekkou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75