feat(device_info_plus): Add User Device Name in Android by FaizanUllahDev · Pull Request #3437 · fluttercommunity/plus_plugins

FaizanUllahDev · 2025-01-20T13:31:58Z

Description

This PR updates the functionality of the NAME property to now include and send the customer's device name. This enhancement ensures that the application can capture and utilize the user device name for better identification, personalization, and debugging. Prior to this change, the NAME property did not include device-specific details. This update significantly improves logging, user tracking, and system behavior analysis.

Related Issues

In the current package, the user is unable to obtain the Android user's custom device name

Fix [Request]: User Defined Device Name [ Android ] #3436

Checklist

I read the [Contributor Guide](https://github.com/fluttercommunity/plus_plugins/blob/main/CONTRIBUTING.md) and followed the process outlined there for submitting PRs.
I titled the PR using [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0).
I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in [Conventional Commits] (https://www.conventionalcommits.org/en/v1.0.0)).
this is not a breaking change.

FaizanUllahDev · 2025-01-20T16:26:26Z

Need Manual Testing

miquelbeltran · 2025-01-20T21:17:23Z

Hello, can you fix the markdown of the PR description, as well as adding the plugin name between ( ) on the PR title?

The feature seems good to me, I'll take a deeper look when I got the time.

miquelbeltran · 2025-01-21T07:32:11Z

The title format is still not right, please read the contributor guidelines and look at other PRs on how it is done

FaizanUllahDev · 2025-01-21T07:46:47Z

Check Now

miquelbeltran · 2025-01-21T08:23:33Z

thanks, although I don't think this is a breaking change

FaizanUllahDev · 2025-01-21T09:39:33Z

Yes! but this change will save the time and give possibles user name of the current user device.

miquelbeltran · 2025-02-03T15:39:09Z

I've been working today on this PR and found several things that need changes, however when I tried to push my changes I've got remote rejected. Can you enable that we can push to your branch?

miquelbeltran · 2025-02-03T15:40:18Z

...o_plus/android/src/main/kotlin/dev/fluttercommunity/plus/device_info/DeviceInfoPlusPlugin.kt

-        val handler = MethodCallHandlerImpl(packageManager, activityManager)
+        val activityManager: ActivityManager =
+            context.getSystemService(Context.ACTIVITY_SERVICE) as ActivityManager
+        val handler = MethodCallHandlerImpl(packageManager, activityManager, context)


Don't pass context here, instead pass the ContentResolver.

miquelbeltran · 2025-02-03T15:41:04Z

..._plus/android/src/main/kotlin/dev/fluttercommunity/plus/device_info/MethodCallHandlerImpl.kt

            build["manufacturer"] = Build.MANUFACTURER
            build["model"] = Build.MODEL
            build["product"] = Build.PRODUCT
+            build["name"] = Settings.Global.getString(context.contentResolver, Settings.Global.DEVICE_NAME)


This API is only available from Android N (API 25), this code needs to check for the version. Android Studio should show a warning.

miquelbeltran · 2025-02-03T15:41:35Z

packages/device_info_plus/device_info_plus/lib/src/model/android_device_info.dart

  final String product;

+  /// The name of the device.
+  /// https://developer.android.com/reference/android/os/Build#NAME


this documentation is incorrect, it should link to https://developer.android.com/reference/android/provider/Settings.Global#DEVICE_NAME

FaizanUllahDev · 2025-02-04T07:20:12Z

I've been working today on this PR and found several things that need changes, however when I tried to push my changes I've got remote rejected. Can you enable that we can push to your branch?

Please check now I set the bypass rule for the update

miquelbeltran · 2025-02-04T07:41:10Z

It won't let me push, probably because the PR was created from main instead of a branch? anyway I added comments on what needs to be changed

FaizanUllahDev · 2025-02-04T07:54:09Z

It won't let me push, probably because the PR was created from main instead of a branch? anyway I added comments on what needs to be changed

I added you as contributor so, I think now you can do changes

miquelbeltran · 2025-02-04T08:30:35Z

ugh what just happened, I pushed and it closed the PR?

miquelbeltran · 2025-02-04T08:31:44Z

Reopening

miquelbeltran · 2025-02-04T08:42:17Z

Well, I don't know. Git is giving me lots of problems, opening a pr from main directly can cause issues. I pushed the code on a new branch in your repo. Create a new PR following this link: https://github.com/fluttercommunity/plus_plugins/compare/main...FaizanUllahDev:plus_plugins:3437?expand=1 and copy the description from this PR.

…3456) Co-authored-by: Miguel Beltran <m@beltran.work>

FaizanUllahDev changed the title ~~Add User Device Name in Android~~ feat: Add User Device Name in Android Jan 20, 2025

FaizanUllahDev marked this pull request as draft January 20, 2025 16:22

FaizanUllahDev marked this pull request as ready for review January 20, 2025 16:24

FaizanUllahDev closed this Jan 20, 2025

FaizanUllahDev reopened this Jan 20, 2025

FaizanUllahDev changed the title ~~feat: Add User Device Name in Android~~ feat: Add User Device Name in Android (device_info_plus) Jan 21, 2025

FaizanUllahDev changed the title ~~feat: Add User Device Name in Android (device_info_plus)~~ feat(device_info_plus)!: Add User Device Name in Android Jan 21, 2025

miquelbeltran changed the title ~~feat(device_info_plus)!: Add User Device Name in Android~~ feat(device_info_plus): Add User Device Name in Android Jan 21, 2025

miquelbeltran added PR: needs review PR: needs manual testing labels Jan 21, 2025

miquelbeltran self-assigned this Jan 28, 2025

miquelbeltran removed PR: needs manual testing PR: needs review labels Feb 3, 2025

miquelbeltran requested changes Feb 3, 2025

View reviewed changes

miquelbeltran closed this Feb 4, 2025

miquelbeltran force-pushed the main branch from 3ffc960 to e499b82 Compare February 4, 2025 08:30

FaizanUllahDev mentioned this pull request Feb 4, 2025

feat(device_info_plus): Add User Device Name in Android (PR #3437) #3456

Merged

7 tasks

miquelbeltran added a commit that referenced this pull request Feb 4, 2025

feat(device_info_plus): Add User Device Name in Android (PR #3437) (#…

8c38a31

…3456) Co-authored-by: Miguel Beltran <m@beltran.work>

github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2026

Uh oh!

Conversation

FaizanUllahDev commented Jan 20, 2025 • edited by miquelbeltran Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

FaizanUllahDev commented Jan 20, 2025

Uh oh!

miquelbeltran commented Jan 20, 2025

Uh oh!

miquelbeltran commented Jan 21, 2025

Uh oh!

FaizanUllahDev commented Jan 21, 2025

Uh oh!

miquelbeltran commented Jan 21, 2025

Uh oh!

FaizanUllahDev commented Jan 21, 2025

Uh oh!

miquelbeltran commented Feb 3, 2025

Uh oh!

miquelbeltran Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

miquelbeltran Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

miquelbeltran Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

FaizanUllahDev commented Feb 4, 2025

Uh oh!

miquelbeltran commented Feb 4, 2025

Uh oh!

FaizanUllahDev commented Feb 4, 2025

Uh oh!

miquelbeltran commented Feb 4, 2025

Uh oh!

miquelbeltran commented Feb 4, 2025

Uh oh!

miquelbeltran commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

FaizanUllahDev commented Jan 20, 2025 •

edited by miquelbeltran

Loading