Skip to content

chore: adding more scenarios for processor_test.go #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025
Merged

chore: adding more scenarios for processor_test.go #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions internal/reconcile/summarize/processor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,43 @@ func TestRecordReconcileReq(t *testing.T) {
t.Expect(obj).To(HaveStatusLastHandledReconcileAt("now"))
},
},
{
name: "empty reconcile annotation value",
beforeFunc: func(obj client.Object) {
annotations := map[string]string{
meta.ReconcileRequestAnnotation: "",
}
obj.SetAnnotations(annotations)
},
afterFunc: func(t *WithT, obj client.Object) {
t.Expect(obj).To(HaveStatusLastHandledReconcileAt(""))
},
},
{
name: "whitespace-only reconcile annotation value",
beforeFunc: func(obj client.Object) {
annotations := map[string]string{
meta.ReconcileRequestAnnotation: " ",
}
obj.SetAnnotations(annotations)
},
afterFunc: func(t *WithT, obj client.Object) {
t.Expect(obj).To(HaveStatusLastHandledReconcileAt(" "))
},
},
{
name: "reconcile annotation overwrites existing status value",
beforeFunc: func(obj client.Object) {
object.SetStatusLastHandledReconcileAt(obj, "old-value")
annotations := map[string]string{
meta.ReconcileRequestAnnotation: "new-value",
}
obj.SetAnnotations(annotations)
},
afterFunc: func(t *WithT, obj client.Object) {
t.Expect(obj).To(HaveStatusLastHandledReconcileAt("new-value"))
},
},
}

for _, tt := range tests {
Expand Down