Skip to content

Conversation

@zhaque44
Copy link
Contributor

@zhaque44 zhaque44 commented Jun 6, 2025

Added test scenarios:

  • Empty/whitespace annotation values Ensures that the func can handle edge cases where the annotation exists but has no meaningful content.
  • Overwrite existing status value Added a test to verify that reconcile annotation updates correctly overwrite any existing status value.

This will overall address edge cases and help with better test coverage

@zhaque44
Copy link
Contributor Author

zhaque44 commented Jun 6, 2025

@matheuscscp updated with squashed commits

@zhaque44 zhaque44 requested a review from matheuscscp June 7, 2025 13:21
@matheuscscp
Copy link
Member

Please squash :) We can only merge a single commit or a history of significant/meaningful commits

Signed-off-by: zhaque44 <[email protected]>

chg imports to be like main

Signed-off-by: zhaque44 <[email protected]>
@zhaque44 zhaque44 force-pushed the update-reconciliation-tests branch from 15f6746 to 8a92986 Compare June 7, 2025 13:40
@zhaque44
Copy link
Contributor Author

zhaque44 commented Jun 7, 2025

Please squash :) We can only merge a single commit or a history of significant/meaningful commits

yes sure no problem

Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@matheuscscp matheuscscp merged commit 483dd69 into fluxcd:main Jun 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants