Add WithSystemCertPool for CA compatibility #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pkg/runtime dependency from v0.76.0 to v0.78.0 and add WithSystemCertPool() options to maintain backward compatibility with the existing extend approach (system CAs + user CA). This ensures source-controller continues to work with both system and user-provided CA certificates, maintaining the same behavior as before the pkg/runtime/secrets API changes. Signed-off-by: cappyzawa <[email protected]>
cappyzawa
force-pushed
the
feat/helm-oci-controllers-runtime-secrets-v078
branch
from
97b95f9 to
ba14962
Compare
cappyzawa
commented
Jul 30, 2025
| }{ | ||
| { | ||
| name: "HTTPS with certSecretRef pointing to non-matching CA cert but public repo URL fails", | ||
| name: "HTTPS with certSecretRef non-matching CA succeeds via system CA pool", |
There was a problem hiding this comment.
This test case update reverts the breaking behavior introduced in PR #1849, which made TLS validation stricter by only accepting user-provided CA certificates.
While this stricter validation was initially considered beneficial for security, it broke backward compatibility. With the restoration of the extend approach (system CAs + user CA) through WithSystemCertPool(), this test now correctly succeeds because:
- The user-provided CA certificate doesn't match the public repository's certificate
- The system CA pool contains the valid CA that can verify the public repository
- Therefore, the connection succeeds via system CA validation
The test name has been updated to "succeeds via system CA pool" to make this behavior explicit for future maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: fluxcd/pkg#995 (and fluxcd/pkg#997)