Merged
Conversation
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Contributor
|
we should block calling tasks from a trace |
Tests verify that @task calls (via __call__ and .aio()) raise TraceDoesNotAllowNestedTasksError when invoked inside a trace context, and that .forward() remains usable as the escape hatch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Verifies that calling a @task inside a @flyte.trace raises a RuntimeUserError with code "TraceDoesNotAllowNestedTasksError" when run through the full local controller pipeline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pingsutw
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task_contextis preserved inside a trace but any task called from within a trace will run as plain python.