ci: Update version extraction in CI workflow#3261
Merged
Conversation
pingsutw
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
samhita-alla and
wild-endeavor
as code owners
Contributor
|
Bito Automatic Review Skipped - Files Excluded |
wild-endeavor
previously approved these changes
Jun 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3261 +/- ##
==========================================
- Coverage 74.71% 74.39% -0.33%
==========================================
Files 276 215 -61
Lines 25020 22488 -2532
Branches 2953 2954 +1
==========================================
- Hits 18693 16729 -1964
+ Misses 5491 4942 -549
+ Partials 836 817 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wild-endeavor
approved these changes
Jun 3, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Atharva <atharvakulkarni172003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#6480
Why are the changes needed?
flytekit on pip got bumped to 1.16 which caused issues with available images
What changes were proposed in this pull request?
Update version extraction in CI
How was this patch tested?
unit test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances unit tests by replacing return statements with assert statements in two test files, improving the validation of test outcomes. These updates are essential for maintaining test integrity following an update to the underlying library version.