Skip to content

ci: Update version extraction in CI workflow #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pingsutw merged 2 commits into from
Jun 3, 2025
Merged

ci: Update version extraction in CI workflow #3261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d630f45
ci: Update version extraction in CI workflow
pingsutw Jun 3, 2025
b57b0fb
fix tests
pingsutw Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pythonpublish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
id: bump
run: |
# from 'refs/tags/v1.2.3' get 1.2.3
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/||')
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/v||')
echo "version=$VERSION" >> $GITHUB_OUTPUT
shell: bash
- name: Build and publish
Expand All @@ -36,7 +36,7 @@ jobs:
- name: Autobump plugin version
run: |
# from 'refs/tags/v1.2.3' get 1.2.3
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/||')
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/v||')
VERSION=$VERSION make -C plugins update_all_versions
shell: bash
- name: Build all Plugins and publish
Expand All @@ -50,7 +50,7 @@ jobs:
id: pypiwait
run: |
# from 'refs/tags/v1.2.3 get 1.2.3' and make sure it's not an empty string
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/||')
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/v||')
if [ -z "$VERSION" ]
then
echo "No tagged version found, exiting"
Expand Down
2 changes: 1 addition & 1 deletion tests/flytekit/unit/core/test_generice_idl_type_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2704,7 +2704,7 @@ def test_union_in_dataclass():
lv = tf.to_literal(ctx, o, pt, lt)
ot = tf.to_python_value(ctx, lv=lv, expected_python_type=pt)

return o == ot
assert o == ot
assert o.result.schema.remote_path == ot.result.schema.remote_path
assert o.result.number == ot.result.number
assert o.schema.remote_path == ot.schema.remote_path
Expand Down
2 changes: 1 addition & 1 deletion tests/flytekit/unit/core/test_type_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2713,7 +2713,7 @@ def test_union_in_dataclass():
lv = tf.to_literal(ctx, o, pt, lt)
ot = tf.to_python_value(ctx, lv=lv, expected_python_type=pt)

return o == ot
assert o == ot
assert o.result.schema.remote_path == ot.result.schema.remote_path
assert o.result.number == ot.result.number
assert o.schema.remote_path == ot.schema.remote_path
Expand Down
Loading