Version hash should include the image from launchPlan.workflow.nodes #3290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The version won’t change if you update the requirements.txt file in the imageSpec and run a launch plan with Pyflyte.
What changes were proposed in this pull request?
This pull request updates the
_get_image_namesmethod inflytekit/remote/remote.pyto handleLaunchPlanentities. The most important change is the addition of logic to extract image names from the nodes of aLaunchPlan's associated workflow.Key Changes:
Enhancement to
_get_image_namesmethod:entityis aLaunchPlan. If true, the method now iterates over the nodes in theLaunchPlan's workflow to collect image names, ensuring proper handling of this entity type. ([flytekit/remote/remote.pyR1341-R1345](https://github.com/flyteorg/flytekit/pull/3290/files#diff-c56afc489e5060224889036253b85ae7c7f1df9f0f7b1130916d9c614293cbb9R1341-R1345))## Tracking issueSummary by Bito
This pull request enhances the `_get_image_names` method in `flytekit/remote/remote.py` by adding logic to handle `LaunchPlan` entities, enabling the correct extraction of image names from associated workflow nodes. This addresses a limitation in the previous implementation.