Add default sort_by to iterate_node_executions #3340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #6676
Why are the changes needed?
Limit & offset pagination only works when the iteration order of the values from the database is deterministic. Without this change in some circumstances it is possible for some nodes to be omitted from the result which is very frustrating/confusing for users.
What changes were proposed in this pull request?
Adds a configurable sort_by option and defaults to ordering nodes by their
created_attimestamp in ASC order.How was this patch tested?
Tested locally in our environment.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request introduces a new configurable `sort_by` option for the `iterate_node_executions` and `iterate_task_executions` functions, enhancing pagination reliability by sorting results deterministically by `created_at`. This modification improves user experience by ensuring clearer and more consistent data retrieval.