Skip to content

Add default sort_by to iterate_node_executions #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pingsutw merged 2 commits into from
Oct 16, 2025
Merged

Add default sort_by to iterate_node_executions #3340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00653f7
Add default sort_by to iterate_node_executions
Sovietaced Oct 14, 2025
4376f71
precommit
Sovietaced Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion flytekit/clients/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
from flytekit.models.admin import common

DEFAULT_SORT_ASC = common.Sort(key="created_at", direction=common.Sort.Direction.ASCENDING)


def iterate_node_executions(
client,
workflow_execution_identifier=None,
task_execution_identifier=None,
limit=None,
filters=None,
sort_by=DEFAULT_SORT_ASC,
unique_parent_id=None,
):
"""
Expand All @@ -13,6 +19,7 @@ def iterate_node_executions(
:param flytekit.models.core.identifier.TaskExecutionIdentifier task_execution_identifier:
:param int limit: The maximum number of elements to retrieve
:param list[flytekit.models.filters.Filter] filters:
:param flytekit.models.admin.common.Sort sort_by: [Optional] Defaults to created_at field in ASC order.
:rtype: Iterator[flytekit.models.node_execution.NodeExecution]
"""
token = ""
Expand All @@ -27,6 +34,7 @@ def iterate_node_executions(
limit=num_to_fetch,
token=token,
filters=filters,
sort_by=sort_by,
unique_parent_id=unique_parent_id,
)
else:
Expand All @@ -35,6 +43,7 @@ def iterate_node_executions(
limit=num_to_fetch,
token=token,
filters=filters,
sort_by=sort_by,
)
for n in node_execs:
counter += 1
Expand All @@ -46,13 +55,14 @@ def iterate_node_executions(
token = next_token


def iterate_task_executions(client, node_execution_identifier, limit=None, filters=None):
def iterate_task_executions(client, node_execution_identifier, limit=None, filters=None, sort_by=DEFAULT_SORT_ASC):
"""
This returns a generator for task executions, given a node execution identifier
:param flytekit.clients.friendly.SynchronousFlyteClient client:
:param flytekit.models.core.identifier.NodeExecutionIdentifier node_execution_identifier:
:param int limit: The maximum number of elements to retrieve
:param list[flytekit.models.filters.Filter] filters:
:param flytekit.models.admin.common.Sort sort_by: [Optional] Defaults to created_at field in ASC order.
:rtype: Iterator[flytekit.models.admin.task_execution.TaskExecution]
"""
token = ""
Expand All @@ -66,6 +76,7 @@ def iterate_task_executions(client, node_execution_identifier, limit=None, filte
limit=num_to_fetch,
token=token,
filters=filters,
sort_by=sort_by,
)
for t in task_execs:
counter += 1
Expand Down
Loading