test(e2e): fix outline tree expansion, method validation, and virtualization handling W-21714868#263
Merged
peternhale merged 6 commits intomainfrom Mar 24, 2026
Merged
Conversation
E2E Test Results SummaryRun: 220 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
E2E Test Results SummaryRun: 264 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
E2E Test Results SummaryRun: 267 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
peternhale
approved these changes
Mar 24, 2026
E2E Test Results SummaryRun: 281 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes e2e outline tests that logged method validation failures (11/12 missing) but silently passed because only
classFoundwas asserted.Root causes fixed:
ensureOutlineTreeFullyVisibleused wrong CSS selectors (.codicon-chevron-right) and double-click expansion (navigates editor, doesn't expand tree). Replaced with keyboard-driven ArrowRight/ArrowDown walk.validateApexSymbolsInOutlineused page-widetext=selectors that false-matched editor content instead of outline rows. Scoped all selectors to.outline-tree/.tree-explorer.collectAllTreeLabelsbroke early on duplicate labels (two constructors both namedApexClassExample). Now uses elementidfor end-detection.textContent()on parent container pulled<style>CSS into debug output. Now queries individual row elements.force: trueon list container.Assertion strengthened:
expect(symbolValidation.allExpectedMethodsFound).toBe(true)— missing methods now fail the test.What issues does this PR fix or reference?
@W-21714868@
Results