fix: add comment warning about grpc compatibility #63
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschneidereit
force-pushed
the
jschneidereit/add-compat-warning
branch
from
fe5673e to
101c4cc
Compare
KaviarasuSakthivadivel
approved these changes
May 14, 2025
mkaufmann
approved these changes
May 14, 2025
| if (!queryTimeout.isZero() && !queryTimeout.isNegative()) { | ||
| log.info("Built stub with queryTimeout={}, interceptors={}", queryTimeout, interceptors.length); | ||
| stub = stub.withDeadlineAfter(queryTimeout.getSeconds(), TimeUnit.SECONDS); | ||
| // COMPATIBILITY WARNING: Do not use Duration overload since older versions of gRPC don't have it |
Contributor
There was a problem hiding this comment.
Please add clarification on why we care about older grpc versions. Our grpc version compatibility story should be documented somewhere, and we might even look into having test cases against the minimum grpc version we want to support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.