Magen: Generate project within GraphNode instead of Tool #109
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 88.64% 80.14% -8.51%
==========================================
Files 166 19 -147
Lines 6886 1284 -5602
Branches 957 179 -778
==========================================
- Hits 6104 1029 -5075
+ Misses 782 255 -527
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
packages/mobile-native-mcp-server/src/workflow/nodes/projectGeneration.ts
Outdated
Show resolved
Hide resolved
packages/mobile-native-mcp-server/src/workflow/nodes/projectGeneration.ts
Show resolved
Hide resolved
| }); | ||
|
|
||
| // Execute the command directly without exposing credentials to LLM | ||
| const output = execSync(command, { encoding: 'utf-8', timeout: 120000 }); |
There was a problem hiding this comment.
this doesn't have to happen for this PR but we now have several nodes which do direct command invocation - we should probably have some sort of command runner class that centralizes this and does things like general error handling, basic command validation and (eventually) progress reporting
ben-zhang-at-salesforce
left a comment
ben-zhang-at-salesforce
left a comment
There was a problem hiding this comment.
looks great!, thanks removing one more tool.
4 participants
What does this PR do?
The
sfmobile-native-project-generationtool requires clientId and callbackURL which are treated as sensitive information by GPT5 in AFV. The AFV then refuses to proceed to the orchestrator. The project generation is moved into node from tool.What issues does this PR fix or reference?
@W-20329818@