fix: sanitize tunnel name before using as config file path#21
Open
iamMrGaurav wants to merge 1 commit intofosrl:mainfrom
Open
fix: sanitize tunnel name before using as config file path#21iamMrGaurav wants to merge 1 commit intofosrl:mainfrom
iamMrGaurav wants to merge 1 commit intofosrl:mainfrom
Conversation
The tunnel name from user-supplied JSON config was used directly in filepath.Join() when writing/removing tunnel config files, allowing path traversal attacks (e.g. name: ../../system32/...). Apply sanitizeServiceName() to the filename in both InstallTunnel and UninstallTunnel, consistent with how the service name is already sanitized. Fixes a potential arbitrary file write/delete as SYSTEM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tunnel name from user-supplied JSON config was used directly
in filepath.Join() when writing/removing tunnel config files,
allowing path traversal attacks (e.g. name: ../../system32/...).
Apply sanitizeServiceName() to the filename in both InstallTunnel
and UninstallTunnel, consistent with how the service name is
already sanitized.
Fixes a potential arbitrary file write/delete as SYSTEM.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
How to test?