Skip to content

fix: sanitize tunnel name before using as config file path #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamMrGaurav wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: sanitize tunnel name before using as config file path #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions managers/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func InstallTunnel(configJSON string) error {
if err := os.MkdirAll(configDir, 0755); err != nil {
return fmt.Errorf("failed to create config directory: %w", err)
}
configPath := filepath.Join(configDir, name+".json")
configPath := filepath.Join(configDir, sanitizeServiceName(name)+".json")
if err := os.WriteFile(configPath, []byte(configJSON), 0600); err != nil {
return fmt.Errorf("failed to write config file: %w", err)
}
Expand Down Expand Up @@ -229,7 +229,7 @@ func UninstallTunnel(name string) error {

// Clean up config file
configDir := filepath.Join(os.Getenv("ProgramData"), config.AppName, "Tunnels")
configPath := filepath.Join(configDir, name+".json")
configPath := filepath.Join(configDir, sanitizeServiceName(name)+".json")
os.Remove(configPath) // Best effort cleanup

return nil
Expand Down