Conversation
Member
Author
|
cc @mds1 if you would like to retain the deploy utility methods I could port over Solady's test suite which does not have testFail* methods and is largely similar as it also initially forked Solmate's test suite Related: #469 (comment) |
Contributor
|
ping @mds1 could you please check comment above? thank you! |
DaniPopes
changed the title
testFail* in forge-std teststestFail* tests
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation to deprecate
testFail*: foundry-rs/foundry#9574deployMockERC721anddeployMockERC20fromStdUtilsas their tests includes large amount oftestFail*tests and is generally outdated. I haven't been able to find thedeploy*methods being used in any public project on Github.Alternatively we could upstream Solady's mocks and tests (which have been updated to not use
testFail*but this feels out of place and would be incomplete (ERC4626, ERC6909, etc.. https://github.com/Vectorized/solady/tree/main/test/utils/mocks). I think it is most common for people to rely on the mocks their library comes with (be it Solmate, Solady or OpenZeppelin) or write their own wrapper around the token implementation.