Skip to content

Conversation

@0xrusowsky
Copy link
Contributor

@0xrusowsky 0xrusowsky commented Aug 21, 2025

Closes #11374

sorry i didn't see we had labeled it as first good issue and only realized when opening the PR 🤷‍♂️

PS: this PR is 90% claude-coded

@0xrusowsky 0xrusowsky linked an issue Aug 21, 2025 that may be closed by this pull request
@0xrusowsky 0xrusowsky moved this to Ready For Review in Foundry Aug 21, 2025
@0xrusowsky 0xrusowsky added this to the v1.4.0 milestone Aug 21, 2025
@0xrusowsky 0xrusowsky requested a review from DaniPopes August 21, 2025 08:28
DaniPopes
DaniPopes previously approved these changes Aug 21, 2025
);

impl<'ast> EarlyLintPass<'ast> for UnsafeCheatcodes {
fn check_item_function(&mut self, ctx: &LintContext<'_>, func: &'ast ItemFunction<'ast>) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want check_expr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, i should have baby-sat claude... fixed

@0xrusowsky 0xrusowsky requested a review from DaniPopes August 21, 2025 09:57
@0xrusowsky 0xrusowsky enabled auto-merge (squash) August 21, 2025 09:57
@0xrusowsky 0xrusowsky merged commit ece0eba into master Aug 21, 2025
22 checks passed
@0xrusowsky 0xrusowsky deleted the rusowsky/geiger branch August 21, 2025 10:11
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Foundry Aug 21, 2025
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Rewrite forge geiger as a lint and deprecate command

3 participants