Skip to content

fix minor comments

635fc45
Select commit
Loading
Failed to load commit list.
Merged

POC: Pure Python NFS client #997

fix minor comments
635fc45
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Feb 5, 2025 in 0s

78.13% (+0.10%) compared to a0a8c3e

View this Pull Request on Codecov

78.13% (+0.10%) compared to a0a8c3e

Details

Codecov Report

Attention: Patch coverage is 82.41135% with 124 lines in your changes missing coverage. Please review.

Project coverage is 78.13%. Comparing base (a0a8c3e) to head (635fc45).

Files with missing lines Patch % Lines
dissect/target/helpers/nfs/demo.py 0.00% 44 Missing ⚠️
dissect/target/helpers/sunrpc/serializer.py 85.09% 31 Missing ⚠️
dissect/target/helpers/nfs/client.py 69.09% 17 Missing ⚠️
dissect/target/helpers/nfs/serializer.py 84.26% 14 Missing ⚠️
dissect/target/helpers/sunrpc/client.py 86.53% 14 Missing ⚠️
dissect/target/helpers/nfs/nfs3.py 98.44% 2 Missing ⚠️
dissect/target/helpers/sunrpc/sunrpc.py 97.36% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
+ Coverage   78.02%   78.13%   +0.10%     
==========================================
  Files         328      335       +7     
  Lines       28919    29624     +705     
==========================================
+ Hits        22565    23146     +581     
- Misses       6354     6478     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.