Skip to content

Require ngio 0.2.3 #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025
Merged

Require ngio 0.2.3 #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a1c820a
Require `ngio>=0.2.3`
tcompa Apr 23, 2025
8e07e98
Update poetry lock
tcompa Apr 23, 2025
124ab8f
fix conftest fixture
lorenzocerrone Apr 23, 2025
67335be
require ngio>=0.2.4
lorenzocerrone Apr 23, 2025
ab843ad
minor projection simplification
lorenzocerrone Apr 23, 2025
5793df7
fix pre-commit
lorenzocerrone Apr 23, 2025
e0d2381
CHANGELOG
tcompa Apr 23, 2025
c42d6ac
Regenerate poetry.lock with poetry v2
tcompa Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# 1.5.0 (a2 prerelease)

* Dependencies:
* Bump `ngio` to `>=0.2.2,<0.3.0`.
* Bump `ngio` to `>=0.2.4,<0.3.0`.
* Tasks:
* Refactor `projection` task to use the new `ngio` API.
* Refactor `copy_ome_zarr_plate` init task to support the upcoming flexibility.
Expand Down
7 changes: 1 addition & 6 deletions fractal_tasks_core/tasks/projection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,16 +121,11 @@ def projection(
roi_table_name, check_type="generic_roi_table"
)

roi_list = []
for roi in table.rois():
roi.z = 0.0
roi.z_length = 1.0
roi_list.append(roi)
table.add(roi, overwrite=True)

# We should have a public API to set reset the rois
# or have a overwrite keyword in the add method
table._rois = {}
table.add(roi_list)
table.consolidate()
logger.info(f"Table {roi_table_name} Projection done")

Expand Down
Loading
Loading