Skip to content

Conversation

@tcompa
Copy link
Collaborator

@tcompa tcompa commented Apr 23, 2025

Closes #941

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

@tcompa tcompa changed the base branch from main to dev-1.5 April 23, 2025 06:26
@tcompa
Copy link
Collaborator Author

tcompa commented Apr 23, 2025

The CI fails when updating ngio to 0.2.3 - cc @lorenzocerrone

@tcompa tcompa linked an issue Apr 23, 2025 that may be closed by this pull request
@lorenzocerrone
Copy link
Collaborator

Hi @tcompa thanks for looking into this. I have a local fix for all errors, but one.
This will require a minor fix in ngio. I will ping it here when the patch is released.
The issue is that ROI tables created in the import_ome_zarr.py do not have an index name.

@github-actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_tasks_core/tasks
  projection.py
Project Total  

This report was generated by python-coverage-comment-action

@lorenzocerrone
Copy link
Collaborator

@tcompa I think the PR is ready to be merged

@tcompa tcompa merged commit d98acd0 into dev-1.5 Apr 23, 2025
16 checks passed
@tcompa tcompa deleted the ngio-023 branch April 23, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong window metadata in projected image?

3 participants