fix(TextEditor): Could not find image node with uploadId#583
Closed
krantheman wants to merge 1 commit intomainfrom
Closed
fix(TextEditor): Could not find image node with uploadId#583krantheman wants to merge 1 commit intomainfrom
krantheman wants to merge 1 commit intomainfrom
Conversation
Contributor
|
@krantheman as discussed this is likely not the real problem. Can we close? |
Member
Author
|
Alright, closing this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pasting images without typing or making immediate edits, the image
srcremains as base64 instead of being updated to the uploaded file URL.This is caused because the content watcher calls
setContent()while images are still uploading, destroying image nodes withuploadIdreferences before the upload callback can update them with the final file URL.Adding a check to skip
setContent()calls when images have theloadingattribute fixes the issue.