fix(ux): init config store from boot when possible#2666
Open
dj12djdjs wants to merge 1 commit intofrappe:developfrom
Open
fix(ux): init config store from boot when possible#2666dj12djdjs wants to merge 1 commit intofrappe:developfrom
dj12djdjs wants to merge 1 commit intofrappe:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Initializes HD Config into boot context.
The reason I added this is because when the helpdesk page loads, it shows the default helpdesk logo for the first couple of seconds until
helpdesk.api.config.get_configfinishes loading, then it will switch to the branding set in settings.This change pre loads those settings so there is no switching of the logo after the page has rendered.