fix: divider margin #508
Merged
fix: divider margin #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloydaf
approved these changes
Jan 8, 2025
Contributor
lloydaf
left a comment
lloydaf
left a comment
There was a problem hiding this comment.
Can we override this programmatically? I feel like maybe we should make this more flexible
Contributor
Author
yes @lloydaf , we can override it! it's pretty flexible but I thought it would be better if it was with the 0.5rem as the first usage of it would already be overwritten |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
### [2.21.2](v2.21.1...v2.21.2) (2025-01-09) ### Bug Fixes * divider margin ([#508](#508)) ([a248920](a248920))
Contributor
|
🎉 This PR is included in version 2.21.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes Divider margins to 0.5rem instead of 1rem as it was too big.
Media
The only place we are currently using looked like this with 1rem:
With 0.5rem it looks as expected:
