Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Apr 2, 2025

  • Update repo-config to 0.12.3
  • Update to repo-config 0.13.1

Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz requested a review from a team as a code owner April 2, 2025 16:11
@Marenz Marenz requested a review from mhrrmk April 2, 2025 16:11
@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Apr 2, 2025
@Marenz Marenz requested a review from llucax April 2, 2025 16:11
@Marenz
Copy link
Contributor Author

Marenz commented Apr 2, 2025

WIP, ci is failing with stuff such as

nox > mypy
py/frequenz/api/common/v1/types/decimal_pb2.pyi:13: error: Skipping analyzing "google": module is installed, but missing library stubs or py.typed marker  [import-untyped]
py/frequenz/api/common/v1/types/decimal_pb2.pyi:20: error: Class cannot subclass "Message" (has type "Any")  [misc]
py/frequenz/api/common/v1/streaming/streaming_event_pb2.pyi:13: error: Skipping analyzing "google": module is installed, but missing library stubs or py.typed marker  [import-untyped]
py/frequenz/api/common/v1/streaming/streaming_event_pb2.pyi:29: error: Class cannot subclass value of type "Any"  

@Marenz
Copy link
Contributor Author

Marenz commented Apr 2, 2025

Actually, CI is failing differenttly XD but my bug above is also a problem

@Marenz
Copy link
Contributor Author

Marenz commented Apr 2, 2025

Correction, apparently the quoted error is just locally, where as the CI is a protolint not found issue

@Marenz
Copy link
Contributor Author

Marenz commented Apr 3, 2025

I suspect someone needs to update the reuqired ci check settings? I don't have access, @llucax maybe?

Signed-off-by: Mathias L. Baumann <[email protected]>
@llucax
Copy link
Contributor

llucax commented Apr 3, 2025

Will do after the review

@llucax llucax added this pull request to the merge queue Apr 3, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit 2b6ba10 Apr 3, 2025
6 checks passed
@llucax
Copy link
Contributor

llucax commented Apr 3, 2025

Oh, damn, you forgot to bump the dependencies to v0.13.1 in pyproject.toml in the second commit.

@Marenz
Copy link
Contributor Author

Marenz commented Apr 3, 2025

Me? You mean the migration script! 😆

@llucax
Copy link
Contributor

llucax commented Apr 3, 2025

Me? You mean the migration script! 😆

Yeah, that could be an addition to the migration script, I also found myself saying "why am I doing this manually" :D

At first I thought about the migration script to be something to run on top of the dependabot PR, but since the dependabot PR had 15 other updates in it (which should be solved now), I started to do a separate PR for this upgrade. Hopefully for the next upgrade we can just push the migration script results to the dependabot PR and that it.

In a not so distant future we can have a github action running the migration script for us and showing any manual steps in the action run summary, so can review it and only have to push the manual fixes, and then we get the github action using a LLM to actually do the manual steps for us 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants