Move location.proto to types/location.proto
#368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the location.proto file into a dedicated types package and updates downstream references accordingly, closing issue #363.
- Moved
location.protointoproto/frequenz/api/common/v1/types/and updated its package declaration. - Updated import paths and fully qualified type references in
microgrid.proto. - Documented the change in
RELEASE_NOTES.md.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| proto/frequenz/api/common/v1/types/location.proto | Updated package to frequenz.api.common.v1.types after relocating the file |
| proto/frequenz/api/common/v1/microgrid/microgrid.proto | Adjusted import path and type reference to the new types.Location |
| RELEASE_NOTES.md | Added note about moving location.proto into the types package |
Comments suppressed due to low confidence (1)
RELEASE_NOTES.md:68
- [nitpick] Clarify the fully qualified protobuf message name in the release note—e.g., use
frequenz.api.common.v1.types.Location—to avoid ambiguity for consumers.
- The file `location.proto` has been moved to the `types` package, moving the message `Location` to `types.Location`.
Signed-off-by: Tiyash Basu <[email protected]>
tiyash-basu-frequenz
force-pushed
the
363_location
branch
from
43cdce7 to
4b64cdb
Compare
github-actions
bot
added
the
part:tests
llucax
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #363