Skip to content

Move location.proto to types/location.proto #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Move location.proto to types/location.proto #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@

- The minimum allowed version of `protobuf` and `grpcio` has been updated to 6.31.1 and 1.72.1 respectively, you might also need to bump your dependencies accordingly.

- The file `location.proto` has been moved to the `types` package, moving the message `Location` to `types.Location`.

## New Features

Added many new messages and enum values:
Expand Down
4 changes: 2 additions & 2 deletions proto/frequenz/api/common/v1/microgrid/microgrid.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ syntax = "proto3";
package frequenz.api.common.v1.microgrid;

import "frequenz/api/common/v1/grid/delivery_area.proto";
import "frequenz/api/common/v1/location.proto";
import "frequenz/api/common/v1/types/location.proto";

import "google/protobuf/timestamp.proto";

Expand Down Expand Up @@ -60,7 +60,7 @@ message Microgrid {
// Physical location of the microgrid, in geographical co-ordinates.
//
// If the location is not known, this field will be missing.
frequenz.api.common.v1.Location location = 5;
frequenz.api.common.v1.types.Location location = 5;

// The current status of the microgrid.
MicrogridStatus status = 6;
Expand Down
2 changes: 1 addition & 1 deletion proto/frequenz/api/common/v1/location.proto → ...equenz/api/common/v1/types/location.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

syntax = "proto3";

package frequenz.api.common.v1;
package frequenz.api.common.v1.types;

// A pair of geographical co-ordinates, representing the location of a place.
message Location {
Expand Down
4 changes: 2 additions & 2 deletions pytests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,12 @@ def test_module_import_microgrid_communication_components() -> None:
def test_module_import_location() -> None:
"""Test that the modules can be imported."""
# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1 import location_pb2
from frequenz.api.common.v1.types import location_pb2

assert location_pb2 is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1 import location_pb2_grpc
from frequenz.api.common.v1.types import location_pb2_grpc

assert location_pb2_grpc is not None

Expand Down
Loading