-
Notifications
You must be signed in to change notification settings - Fork 7
Use new definitions from api-common #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8ea286d to
0e4282a
Compare
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependency versions and migrates proto definitions to use the new api-common layout.
- Updated pyproject.toml to use a Git URL for frequenz-api-common and adjusted the protobuf version.
- Revised dispatch.proto to import and use definitions from the new electrical_components and types namespaces.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Downgraded protobuf version and switched frequenz-api-common dependency to a Git URL. |
| proto/frequenz/api/dispatch/v1/dispatch.proto | Updated imports and type references to the new api-common definitions. |
Files not reviewed (1)
- submodules/frequenz-api-common: Language not supported
| # versions can't work with code that was generated with newer versions. | ||
| # https://protobuf.dev/support/cross-version-runtime-guarantee/#backwards | ||
| "protobuf == 5.29.4", | ||
| "protobuf == 5.29.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis is to match the common api version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, interesting. I wonder if there is a better way to do this, it kind of sucks to have such a strong interdependence...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, if this is about the protobuf message about runtime and build version mismatch, using different point releases of the same minor should work. Are you sure this is really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to make the jump to an unrelated unreleased common API?
|
what do you mean unrelated? |
|
Sorry, typo, I meant unreleased. |
No, sadly this also translate to Python dependencies. |
|
Which means this code won't be usable with the SDK unless the microgrid API client also uses exactly the same git hash as dispatch. |
|
If we want to keep the development so we don´t need to do a huge update after the |
fixes #242
WIP - not yet implemented in common