-
Notifications
You must be signed in to change notification settings - Fork 7
Use new definitions from api-common #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ requires = [ | |
| # sure the code is generated using the minimum supported versions, as older | ||
| # versions can't work with code that was generated with newer versions. | ||
| # https://protobuf.dev/support/cross-version-runtime-guarantee/#backwards | ||
| "protobuf == 5.29.4", | ||
| "protobuf == 5.29.3", | ||
| "grpcio-tools == 1.70.0", | ||
| "grpcio == 1.70.0", | ||
| ] | ||
|
|
@@ -43,7 +43,8 @@ classifiers = [ | |
| ] | ||
| requires-python = ">= 3.11, < 4" | ||
| dependencies = [ | ||
| "frequenz-api-common >= 0.5.4, < 0.7", | ||
| # "frequenz-api-common >= 0.5.4, < 0.7", | ||
| "frequenz-api-common @ git+http://[email protected]/frequenz-floss/[email protected]", | ||
| "googleapis-common-protos >= 1.65.0, < 2", | ||
| # We can't widen beyond the current value unless we bump the minimum | ||
| # requirements too because of protobuf cross-version runtime guarantees: | ||
|
|
@@ -90,7 +91,7 @@ dev-mypy = [ | |
| ] | ||
| dev-noxfile = ["nox == 2025.5.1", "frequenz-repo-config[api] == 0.13.3"] | ||
| dev-pylint = [ | ||
| "pylint == 3.3.6", | ||
| "pylint == 3.3.7", | ||
| # For checking the noxfile, docs/ script, and tests | ||
| "frequenz-api-dispatch[dev-mkdocs,dev-noxfile,dev-pytest]", | ||
| ] | ||
|
|
||
Submodule frequenz-api-common
updated
27 files
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis is to match the common api version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, interesting. I wonder if there is a better way to do this, it kind of sucks to have such a strong interdependence...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, if this is about the protobuf message about runtime and build version mismatch, using different point releases of the same minor should work. Are you sure this is really needed?