Add support to restart a stream #141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias L. Baumann <[email protected]>
github-actions
bot
added
part:docs
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for restarting streams by introducing a reconnect mechanism that cancels the current task and starts a new one.
- Added a reconnect() method in streaming.py to cancel and reinitialize the streaming task.
- Updated RELEASE_NOTES.md to document the new stream restart functionality.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/frequenz/client/base/streaming.py | Added reconnect() to handle stream restarts |
| RELEASE_NOTES.md | Updated release notes to include restart support note |
llucax
reviewed
May 22, 2025
| limit=maxsize, warn_on_overflow=warn_on_overflow | ||
| ) | ||
|
|
||
| def reconnect(self) -> None: |
There was a problem hiding this comment.
I would call this restart_stream() for extra clarity.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Mathias L. Baumann <[email protected]>
github-merge-queue bot
pushed a commit
to frequenz-floss/frequenz-dispatch-python
that referenced
this pull request
Jun 25, 2025
Should probably use frequenz-floss/frequenz-client-base-python#141 eventually to be less hacky?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.