-
Couldn't load subscription status.
- Fork 4
Widen base-client dependency to 0.12.0 #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR widens the version range for the frequenz-client-base dependency to support upcoming stream-reconnect features.
- Updated dependency version requirement in pyproject.toml
- Ensures compatibility with future base client enhancements
Comments suppressed due to low confidence (1)
pyproject.toml:41
- Widening the dependency range may introduce unexpected changes in the base client's API. Please ensure that integration tests cover any breaking changes or new behaviors introduced in versions between 0.10.0 and 0.12.0.
"frequenz-client-base >= 0.8.0, < 0.12.0",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI says no.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe split in 3 commits?
In anticipation of the stream-reconnect feature in the base client. Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
In anticipation of the stream-reconnect feature in the base client.