Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented May 26, 2025

In anticipation of the stream-reconnect feature in the base client.

Copilot AI review requested due to automatic review settings May 26, 2025 16:49
@Marenz Marenz requested review from a team as code owners May 26, 2025 16:49
@github-actions github-actions bot added part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:dispatcher labels May 26, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR widens the version range for the frequenz-client-base dependency to support upcoming stream-reconnect features.

  • Updated dependency version requirement in pyproject.toml
  • Ensures compatibility with future base client enhancements
Comments suppressed due to low confidence (1)

pyproject.toml:41

  • Widening the dependency range may introduce unexpected changes in the base client's API. Please ensure that integration tests cover any breaking changes or new behaviors introduced in versions between 0.10.0 and 0.12.0.
"frequenz-client-base >= 0.8.0, < 0.12.0",

llucax
llucax previously approved these changes May 27, 2025
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI says no.

@Marenz

This comment was marked as outdated.

@Marenz Marenz requested a review from llucax May 27, 2025 08:24
@Marenz Marenz enabled auto-merge May 27, 2025 08:45
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe split in 3 commits?

Marenz added 3 commits May 27, 2025 16:17
In anticipation of the stream-reconnect feature in the base client.

Signed-off-by: Mathias L. Baumann <[email protected]>
Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz disabled auto-merge May 27, 2025 14:24
@Marenz Marenz enabled auto-merge May 27, 2025 14:24
@Marenz Marenz disabled auto-merge May 27, 2025 14:28
@Marenz Marenz merged commit 8db06d9 into frequenz-floss:v0.x.x May 27, 2025
5 checks passed
@Marenz Marenz deleted the basecl branch May 27, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:dispatcher part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants