Rename objects returned by calls to response internally
#179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some clarity, as we are getting a response that has the microgrid, connection list, and component list inside them as a field, instead of getting the objects directly. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
requested review from
ela-kotulska-frequenz and
hannah-stevenson-frequenz
There was a problem hiding this comment.
Pull Request Overview
This PR improves code clarity by renaming variables that store gRPC response objects to better reflect their nature as response containers rather than the domain objects they contain.
- Renamed
microgrid,component_list, andconnection_listvariables toresponseto clarify they contain response wrappers - Updated corresponding field access to use the renamed
responsevariable - Simplified the connection mapping logic by removing unnecessary line breaks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
llucax
added
cmd:skip-release-notes
tiyash-basu-frequenz
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some clarity, as we are getting a response that has the microgrid, connection list, and component list inside them as a field, instead of getting the objects directly.