Skip to content

Rename objects returned by calls to response internally #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

Rename objects returned by calls to response internally #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/frequenz/client/microgrid/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ async def get_microgrid_info( # noqa: DOC502 (raises ApiClientError indirectly)
most likely a subclass of
[GrpcError][frequenz.client.microgrid.GrpcError].
"""
microgrid = await client.call_stub_method(
response = await client.call_stub_method(
self,
lambda: self.stub.GetMicrogridMetadata(
Empty(),
Expand All @@ -166,7 +166,7 @@ async def get_microgrid_info( # noqa: DOC502 (raises ApiClientError indirectly)
method_name="GetMicrogridMetadata",
)

return microgrid_info_from_proto(microgrid.microgrid)
return microgrid_info_from_proto(response.microgrid)

async def list_components( # noqa: DOC502 (raises ApiClientError indirectly)
self,
Expand Down Expand Up @@ -209,7 +209,7 @@ async def list_components( # noqa: DOC502 (raises ApiClientError indirectly)
most likely a subclass of
[GrpcError][frequenz.client.microgrid.GrpcError].
"""
component_list = await client.call_stub_method(
response = await client.call_stub_method(
self,
lambda: self.stub.ListComponents(
microgrid_pb2.ListComponentsRequest(
Expand All @@ -221,7 +221,7 @@ async def list_components( # noqa: DOC502 (raises ApiClientError indirectly)
method_name="ListComponents",
)

return map(component_from_proto, component_list.components)
return map(component_from_proto, response.components)

async def list_connections( # noqa: DOC502 (raises ApiClientError indirectly)
self,
Expand Down Expand Up @@ -263,7 +263,7 @@ async def list_connections( # noqa: DOC502 (raises ApiClientError indirectly)
most likely a subclass of
[GrpcError][frequenz.client.microgrid.GrpcError].
"""
connection_list = await client.call_stub_method(
response = await client.call_stub_method(
self,
lambda: self.stub.ListConnections(
microgrid_pb2.ListConnectionsRequest(
Expand All @@ -277,9 +277,7 @@ async def list_connections( # noqa: DOC502 (raises ApiClientError indirectly)

return (
conn
for conn in map(
component_connection_from_proto, connection_list.connections
)
for conn in map(component_connection_from_proto, response.connections)
if conn is not None
)

Expand Down
Loading