Add a function to get a public logger for a module #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:tests
llucax
added
the
cmd:skip-release-notes
This function will return a logger for the public module containing the given module name. This is useful to make sure that logger name only reference public modules, which are the ones that the user imports and interacts with. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
changed the title
Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
the
part:tooling
|
Enabled auto-merge. |
|
Skipping release notes because since this is unreleased, I will write some special release notes for the initial release. |
Marenz
reviewed
Jul 24, 2024
| @@ -0,0 +1,38 @@ | |||
| # License: MIT | |||
| # Copyright © 2023 Frequenz Energy-as-a-Service GmbH | |||
There was a problem hiding this comment.
We should probably remove these copyright years, from the legal perspective they seem to be useless and we always get them wrong, and it makes testing templates harder, as we need to make the test change every year...
Marenz
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function will return a logger for the public module containing the given module name. This is useful to make sure that logger name only reference public modules, which are the ones that the user imports and interacts with.
Implements the function suggested in frequenz-floss/frequenz-sdk-python#1009.