-
Couldn't load subscription status.
- Fork 2
Add a function to get a public logger for a module #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # License: MIT | ||
| # Copyright © 2023 Frequenz Energy-as-a-Service GmbH | ||
|
|
||
| """Logging tools.""" | ||
|
|
||
| import logging | ||
|
|
||
|
|
||
| def get_public_logger(module_name: str) -> logging.Logger: | ||
| """Get a logger for the public module containing the given module name. | ||
|
|
||
| * Modules are considered private if they start with `_`. | ||
| * All modules inside a private module are also considered private, even if they | ||
| don't start with `_`. | ||
| * If there is no leading public part, the root logger is returned. | ||
|
|
||
| Example: | ||
| Here are a few examples of how this function will resolve module names: | ||
|
|
||
| * `some.pub` -> `some.pub` | ||
| * `some.pub._some._priv` -> `some.pub` | ||
| * `some.pub._some._priv.public` -> `some.pub` | ||
| * `some.pub._some._priv.public._private` -> `some.pub` | ||
| * `_priv` -> `root` | ||
|
|
||
| Args: | ||
| module_name: The fully qualified name of the module to get the logger for | ||
| (normally the `__name__` built-in variable). | ||
|
|
||
| Returns: | ||
| The logger for the public module containing the given module name. | ||
| """ | ||
| public_parts: list[str] = [] | ||
| for part in module_name.split("."): | ||
| if part.startswith("_"): | ||
| break | ||
| public_parts.append(part) | ||
| return logging.getLogger(".".join(public_parts)) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # License: MIT | ||
| # Copyright © 2024 Frequenz Energy-as-a-Service GmbH | ||
|
|
||
| """Tests for the log module.""" | ||
|
|
||
|
|
||
| import pytest | ||
|
|
||
| from frequenz.core.logging import get_public_logger | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "module_name, expected_logger_name", | ||
| [ | ||
| ("some.pub", "some.pub"), | ||
| ("some.pub._some._priv", "some.pub"), | ||
| ("some.pub._some._priv.public", "some.pub"), | ||
| ("some.pub._some._priv.public._private", "some.pub"), | ||
| ("some._priv.pub", "some"), | ||
| ("_priv.some.pub", "root"), | ||
| ("some", "some"), | ||
| ("some._priv", "some"), | ||
| ("_priv", "root"), | ||
| ], | ||
| ) | ||
| def test_get_public_logger(module_name: str, expected_logger_name: str) -> None: | ||
| """Test that the logger name is as expected.""" | ||
| logger = get_public_logger(module_name) | ||
| assert logger.name == expected_logger_name |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably remove these copyright years, from the legal perspective they seem to be useless and we always get them wrong, and it makes testing templates harder, as we need to make the test change every year...