Use keyword arguments #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwasicki
previously approved these changes
Oct 2, 2024
flora-hofmann-frequenz
force-pushed
the
arguments_error
branch
from
3585b1c to
38a3c90
Compare
|
Oh, since we have already a release we need release notes :( |
cwasicki
reviewed
Oct 2, 2024
RELEASE_NOTES.md
Outdated
| ## Bug Fixes | ||
|
|
||
| * Change 0.0 to nan if there is no data available | ||
| * Make use of keyword arguments |
There was a problem hiding this comment.
Enforce keyword arguments in cumulative_energy function.
Signed-off-by: Flora <[email protected]>
flora-hofmann-frequenz
force-pushed
the
arguments_error
branch
from
38a3c90 to
cbb7e19
Compare
cwasicki
approved these changes
Oct 2, 2024
|
If you don't want to change your code accordingly (as in, use key-word arguments), you can also just add a new exception: |
llucax
reviewed
Oct 3, 2024
| ## Bug Fixes | ||
|
|
||
| * Change 0.0 to nan if there is no data available | ||
| * Enforce keyword arguments in cumulative_energy function |
There was a problem hiding this comment.
Nitpick, but this is not really a bug fix, I would say it's more of an improvement, and a breaking change, as now callers must use keyword arguments. So in the future you might want to mention it in the Upgrading section.
There was a problem hiding this comment.
Will do so - we have the same topic coming up in the client, so I will change it there :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help fix nox error in PR #13.