Skip to content

Use keyword arguments #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Use keyword arguments #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@
## Bug Fixes

* Change 0.0 to nan if there is no data available
* Enforce keyword arguments in cumulative_energy function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but this is not really a bug fix, I would say it's more of an improvement, and a breaking change, as now callers must use keyword arguments. So in the future you might want to mention it in the Upgrading section.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do so - we have the same topic coming up in the client, so I will change it there :-)

1 change: 1 addition & 0 deletions src/frequenz/reporting/_reporting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

# pylint: disable-next=too-many-arguments
async def cumulative_energy(
*,
client: ReportingApiClient,
microgrid_id: int,
component_id: int,
Expand Down
Loading