Remove request_timeout parameter from propose_power methods
#1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
part:docs
shsms
changed the title
request_timeout parameter from propose_power methodsrequest_timeout parameter from propose_power methods
llucax
reviewed
Jul 8, 2024
| Args: | ||
| resampler_config: Config to pass on to the resampler. | ||
| api_power_request_timeout: Timeout to use when making power requests to | ||
| the microgrid API. |
There was a problem hiding this comment.
Maybe it would be good to document what happens if it times out? As a user I'm not sure what to do with this. Why should I increase or decrease the timeout?
There was a problem hiding this comment.
I've added a few more lines. The only thing is that I've not been specific about the exact duration for which the components get blocked, because currently it is hard-coded to exponentially increase from 1s to a max of 30s when there are subsequent timeouts.
I think we don't have to provide a way to change the duration until we can do so from the UI.
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
llucax
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the power manager was introduced, the
request_timeoutparameter was used to specify a different timeout for theset_powercalls made to the api service.The
propose_powermethod is much more high level and it no longer makes sense to provide arequest_timeoutparameter, because it could conflict with other proposals and it would be hard to figure out which timeout to use.From now on, it may be specified at application startup, through the new optional
api_power_request_timeoutparameter in themicrogrid.initialize()method.