Remove power distribution results from Report objects
#998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tests
|
Draft until channel release with |
shsms
force-pushed
the
separate-power-dist-results
branch
2 times, most recently
from
a6a50ca to
09e286e
Compare
|
Based on #1000. |
This is to be able to use the `filter` feature on `Receiver`s that was added in v1.1.0. Signed-off-by: Sahas Subramanian <[email protected]>
This can be used in the BatteryPool that users can use to get a direct stream of the power distributor results. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
force-pushed
the
separate-power-dist-results
branch
from
09e286e to
0927cb9
Compare
|
This is now ready. |
Who doesn't like to get involved in a nice and long name discussion? 😆 |
shsms
force-pushed
the
separate-power-dist-results
branch
from
9423ee9 to
21ef039
Compare
This is a `ReceiverFetcher` which can be used to modify newly created receivers, for example by applying a `map` or a `filter` on them, before returning them. Signed-off-by: Sahas Subramanian <[email protected]>
This would stream results only for the batteries that are part of the pool. Signed-off-by: Sahas Subramanian <[email protected]>
And replace them with the separate distribution result stream from `*Pool`s, like `battery_pool.power_distribution_results.new_receiver()` for battery pools. The `distribution_result` field from the `Report` classes would be removed in subsequent commits. Signed-off-by: Sahas Subramanian <[email protected]>
This should reduce the number of `Report`s sent out by the PowerManager. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
shsms
force-pushed
the
separate-power-dist-results
branch
from
21ef039 to
f0128f0
Compare
llucax
approved these changes
Jul 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, this PR makes the power distribution results available directly from the
*Pools.This should go some way towards reducing the frequency of
Reportobjects as reported in #818