Skip to content

Reorganize the config module #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2024
Merged

Reorganize the config module #1126

merged 4 commits into from
Dec 6, 2024

Conversation

@llucax
Copy link
Contributor

@llucax llucax commented Dec 5, 2024

  • Rename _config_managing.py to _managing_actor.py
  • Rename LoggingConfigUpdater to LoggingConfigUpdatingActor
  • Rename _logging_config_updater.py to _logging_actor.py
  • Fix example in LoggingConfigUpdatingActor

llucax added 4 commits December 5, 2024 14:46
@llucax
Rename _config_managing.py to _managing_actor.py
061952a 
As this package gets more stuff, the old name used when the actor was
stored in the `frequenz.actor` package doesn't make much sense and is
confusing.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Rename LoggingConfigUpdater to LoggingConfigUpdatingActor
646de5c 
This is to follow the naming convention of actors and make it more
obvious that it is an actor.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Rename _logging_config_updater.py to _logging_actor.py
9bf7e7f 
Also rename the test file name to match the new module name.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Fix example in LoggingConfigUpdatingActor
d1b80f3 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax requested a review from a team as a code owner December 5, 2024 13:48
@llucax llucax requested review from Marenz and removed request for a team December 5, 2024 13:48
@llucax llucax self-assigned this Dec 5, 2024
@llucax llucax added this to the v1.0.0-rc1500 milestone Dec 5, 2024
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:config Affects the configuration management labels Dec 5, 2024
@llucax
Copy link
Contributor Author

llucax commented Dec 5, 2024

This is in preparation for a major revamp of the config module.

@llucax llucax enabled auto-merge December 5, 2024 13:48
@llucax llucax added type:enhancement New feature or enhancement visitble to users type:tech-debt Improves the project without visible changes for users labels Dec 5, 2024
@llucax llucax mentioned this pull request Dec 5, 2024
Merged
@llucax llucax added the scope:breaking-change Breaking change, users will need to update their code label Dec 5, 2024
@llucax llucax added this pull request to the merge queue Dec 6, 2024
Merged via the queue into frequenz-floss:v1.x.x with commit 54735f7 Dec 6, 2024
21 checks passed
@llucax llucax deleted the config-reorg branch December 6, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ela-kotulska-frequenz ela-kotulska-frequenz ela-kotulska-frequenz approved these changes

@Marenz Marenz Awaiting requested review from Marenz Marenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

@cwasicki cwasicki Awaiting requested review from cwasicki

Assignees

@llucax llucax

Labels

part:config Affects the configuration management part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users type:tech-debt Improves the project without visible changes for users

Projects

Python SDK Roadmap
Status: Done

Milestone

v1.0.0-rc1500

Development

Successfully merging this pull request may close these issues.

2 participants

@llucax @ela-kotulska-frequenz