Attempt to fix ci-gets-stuck in shutdown loop #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:tooling
Marenz
force-pushed
the
ci-stuck-test
branch
4 times, most recently
from
cac8172 to
e468e9f
Compare
github-actions
bot
added
the
part:microgrid
Marenz
changed the title
Marenz
added
the
cmd:skip-release-notes
llucax
reviewed
Jun 19, 2025
Comment on lines
265
to
267
| while True: | ||
| # To prevent entering a shutdown-loop, we explicitly check if there is | ||
| # an eventloop running | ||
| while asyncio.get_event_loop().is_running(): |
There was a problem hiding this comment.
Shouldn't this stop when there is an exception (like there is no loop)? Or is this being run in some other run_forever() or something like that?
There was a problem hiding this comment.
It's more about preventing it to start in the first place. The proper way is probably to do this check in select in the channels repo
There was a problem hiding this comment.
But I think it is fine, if there is no loop an exception is raised in select(), the issue is we are blindly looping on broken code forever.
github-actions
bot
added
the
part:tests
github-actions
bot
added
the
part:core
Marenz
force-pushed
the
ci-stuck-test
branch
2 times, most recently
from
2ed033f to
5e0bf82
Compare
Signed-off-by: Leandro Lucarella <[email protected]>
If the test raised an exception in the middle of the test, the `ComponentPoolStatusTracker` was not stopped, which caused the `ComponentPoolStatusTracker` to keep running and entering a restart loop when the asyncio event loop was closed. Signed-off-by: Leandro Lucarella <[email protected]>
We suspect that the CI is stuck because the forever loop is not sleeping when no exception occurs. Signed-off-by: Mathias L. Baumann <[email protected]>
We detect if the asyncio event loop is not running and log an error message and exit instead of retrying. Signed-off-by: Leandro Lucarella <[email protected]>
`run_forever()` is now more resilient to issues with no running asyncio event loop, so it is better to use that instead of our custom naïve loop. Signed-off-by: Leandro Lucarella <[email protected]>
Marenz
requested review from
florian-wagner-frequenz and
shsms
and removed request for
a team and
florian-wagner-frequenz
llucax
approved these changes
Jun 19, 2025
github-project-automation
bot
moved this from Review in progress
to Review approved
in Python SDK Roadmap
shsms
approved these changes
Jun 19, 2025
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to find the dependency that causes the CI to get stuck (the _max test works so it must be a min dependency)