-
Couldn't load subscription status.
- Fork 20
Remove setitem magic from ring buffer #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me, my only question is if it doesn't make sense to make __setitem__ use update underneath, to keep the buffer's standard interface, it might come handy at some point if interacting with generic functions, for example from the stdlib.
014ce7d to
e70c93b
Compare
|
Updated.
In fact both methods are not doing the same. We could still add the setter magic back in future if required, but at the moment I am not sure how exactly that should look like. |
The method is missing wrapping of the index and therefore lacks the essential functionality that the ring buffer should provide. Instead, the `update` function should be used. So far this method is only used in a very specific unit test. Signed-off-by: cwasicki <[email protected]>
|
Resolved conflicts in release notes. |
|
This was removed from the merge queue due to #662. Re-queuing. |
The method is missing wrapping of the index and therefore lacks the essential functionality that the ring buffer should provide. Instead, the
updatefunction should be used. So far this method is only used in a very specific unit test.